Skip to content

Fixes #88 by adding cwd initialConfig and configProps to package.json #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rkeithhill
Copy link
Contributor

Also updated examples.vscode\launch.json file. Sorry, couldn't resist replacing tabs with spaces. :-)

…ckage.json

Also updated examples\launch.json file. Sorry, couldn't resist replacing tabs with spaces. :-)
Forget to add the changes to launch.json
@daviwil
Copy link
Contributor

daviwil commented Feb 7, 2016

No problem on the conversion, I set my VS Code settings to auto convert now, so I've been converting every file I touch ;)

daviwil added a commit that referenced this pull request Feb 7, 2016
Fixes #88 by adding cwd initialConfig and configProps to package.json
@daviwil daviwil merged commit a1a805f into PowerShell:master Feb 7, 2016
@rkeithhill
Copy link
Contributor Author

BTW what's up with the vscode-powershell\.vscode\launch.json file? Does it need to be updated.

@rkeithhill
Copy link
Contributor Author

I should have added in the comment that in this release of VSCode most of the debugger parameter description have been modified to indicate that you should pass only an absolute path. No more workspace relative paths (use ${workspaceRoot} instead).

@daviwil
Copy link
Contributor

daviwil commented Feb 7, 2016

That's supposed to be for debugging the extension itself. Apparently it isn't working lately because someone tried to use it recently and said it didn't work :) probably should fix it at some point as the TypeScript we have here is getting larger.

@daviwil
Copy link
Contributor

daviwil commented Feb 7, 2016

That's OK, we may need to start writing some documentation to capture this stuff anyway.

@rkeithhill
Copy link
Contributor Author

Ah, sounds like a definite postpone then. :-)

@daviwil
Copy link
Contributor

daviwil commented Feb 7, 2016

Yep!

@rkeithhill rkeithhill deleted the rkeithhill/add-cwd-args-dbgparams branch March 26, 2016 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants